-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Local Build Caching and Apply Optimizations #2656
Open
tylerbertrand
wants to merge
4
commits into
OpenFeign:master
Choose a base branch
from
tylerbertrand:tylerbertrand/develocity-optimizations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enable Local Build Caching and Apply Optimizations #2656
tylerbertrand
wants to merge
4
commits into
OpenFeign:master
from
tylerbertrand:tylerbertrand/develocity-optimizations
+28
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbertrand
force-pushed
the
tylerbertrand/develocity-optimizations
branch
from
November 14, 2024 18:36
f2d303f
to
7a4c6b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- annotation-error-decoder/pom.xml
- lines 49-48
- apt-test-generator/pom.xml
- lines 62-61
- benchmark/pom.xml
- lines 70-69
- core/pom.xml
- lines 37-36
- googlehttpclient/pom.xml
- lines 54-53
- hc5/pom.xml
- lines 67-66
- httpclient/pom.xml
- lines 75-74
- hystrix/pom.xml
- lines 78-77
- jackson-jaxb/pom.xml
- lines 82-83
- java11/pom.xml
- lines 50-49
- jaxb-jakarta/pom.xml
- lines 34-35
- lines 55-57
- jaxb/pom.xml
- lines 45-49
- jaxrs2/pom.xml
- lines 103-102
- jaxrs3/pom.xml
- lines 89-88
- jaxrs4/pom.xml
- lines 83-82
- kotlin/pom.xml
- lines 71-70
- okhttp/pom.xml
- lines 59-58
- pom.xml
- lines 594-595
- reactive/pom.xml
- lines 98-97
- ribbon/pom.xml
- lines 83-82
- soap-jakarta/pom.xml
- lines 34-35
- lines 63-62
- lines 79-81
- soap/pom.xml
- lines 55-60
- lines 70-71
velo
approved these changes
Dec 9, 2024
kdavisk6
approved these changes
Jan 4, 2025
This is an identifier captured by Develocity used to uniquely represent a given workspace should not be committed
Don't add PR comment with build scan links - scans aren't published for PR builds against forks
Interesting, I'm seeing the same thing, let me update the branch and see if that fixes it |
tylerbertrand
force-pushed
the
tylerbertrand/develocity-optimizations
branch
from
January 7, 2025 20:08
6a18ac5
to
98f387b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable local build caching with Develocity, so that goals whose inputs have not changed do not need to be re-executed. This should help reduce local build times when making contributions to Feign (note that it is required to run the clean lifecycle phase - i.e.
./mvnw clean install
vs just./mvnw install
- to store outputs to the build cache).Resolve a cache miss by normalizing manifest files so that timestamps in them do not cause goals to be needlessly re-executed. This cache miss was discovered by executing the Develocity Build Validation Scripts for Maven against the project.
Apply the develocity-actions/setup-maven action to help surface Build Scan links